fix(internal/librarian/nodejs): skip writeRepoMetadata when file is in keep list#4791
Merged
julieqiu merged 2 commits intogoogleapis:mainfrom Mar 24, 2026
Merged
Conversation
…n keep list The writeRepoMetadata function unconditionally overwrites .repo-metadata.json after combine-library runs, even when the file is in the library's keep list. The keep/restore logic correctly preserves the file, but writeRepoMetadata then replaces it with a generated version that differs in formatting and content. This checks for .repo-metadata.json in the keep list before calling writeRepoMetadata, so that existing repo metadata files are preserved during generation. For googleapis#4413 For googleapis#4743
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4791 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 129 129
Lines 10875 10876 +1
=======================================
+ Hits 8836 8837 +1
Misses 1396 1396
Partials 643 643 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly prevents writeRepoMetadata from overwriting .repo-metadata.json when it is present in the library's keep list. The change is implemented by adding a check before the function call and is accompanied by a new test case that verifies the intended behavior. The implementation is clear, correct, and well-tested.
jameslynnwu
approved these changes
Mar 24, 2026
Signed-off-by: Julie Qiu <julieqiu@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeRepoMetadata unconditionally overwrites .repo-metadata.json after combine-library runs, even when the file is in the library's keep list. The keep/restore logic correctly preserves the file, but writeRepoMetadata then replaces it with a generated version that differs in formatting and content.
This checks for .repo-metadata.json in the keep list before calling writeRepoMetadata, so that existing repo metadata files are preserved during generation.
For #4743