refactor(internal/librarian/java): rename generateRepoMetadata and move to repometadata.go#4839
refactor(internal/librarian/java): rename generateRepoMetadata and move to repometadata.go#4839zhumin8 wants to merge 8 commits intogoogleapis:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the generation of repository metadata for Java libraries. The deriveRepoMetadata function and its associated test have been moved from internal/librarian/java/postprocess.go to internal/librarian/java/repometadata.go. The generate.go file now calls the refactored generateRepoMetadata function earlier in the process, and the original postProcessLibrary function in generate.go now returns nil as its responsibilities have been shifted. A minor typo in a comment was noted.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4839 +/- ##
==========================================
+ Coverage 81.37% 81.49% +0.12%
==========================================
Files 130 130
Lines 10905 10917 +12
==========================================
+ Hits 8874 8897 +23
+ Misses 1392 1380 -12
- Partials 639 640 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
be76d9a to
ae507c4
Compare
Move logic to generate repo metadata into repometadata.go, and move it before client code generation. Moved transport rename logic to serviceconfig package.
For #4308