fix!: Remove support for nested maps and harden validation#196
Draft
dishaprakash wants to merge 2 commits intomainfrom
Draft
fix!: Remove support for nested maps and harden validation#196dishaprakash wants to merge 2 commits intomainfrom
dishaprakash wants to merge 2 commits intomainfrom
Conversation
dishaprakash
changed the title
twishabansal
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict Schema Rules: Updated ValidateDefinition and ValidateType in types.go to explicitly reject nested maps and objects, enforcing flat parameter structures.
Delayed Validation: Moved the type validation of bound parameters to execution time (Invoke in tools.go).
Schema Retention: Added a boundParamSchemas map to the ToolboxTool struct to store parameter definitions for use during runtime validation.
OpenAPI Hardening: Updated schemaToMap in utils.go to safely process supported structures while rejecting nested map configurations.
Testing: Expanded types_test.go and client_test.go to thoroughly cover the new delayed validation and strict structural rules.