-
Notifications
You must be signed in to change notification settings - Fork 23
fix(toolbox-langchain): Expose auth requirements from underlying core tool #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anubhav756
wants to merge
4
commits into
main
Choose a base branch
from
anubhav-state-lc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcf2143
to
3fe904a
Compare
1cef9c2
to
11f4718
Compare
Do we plan to add tests for this? |
d42e234
to
d25545b
Compare
11f4718
to
5a98405
Compare
5a98405
to
40b8221
Compare
Added. Thanks for pointing that out. |
kurtisvg
requested changes
Jun 30, 2025
937b1fc
to
1d2a960
Compare
34497fd
to
20b7968
Compare
20b7968
to
501be35
Compare
501be35
to
3ecad9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the authentication and authorization requirements from the underlying
toolbox-core
'sToolboxTool
as properties on thetoolbox-langchain
'sToolboxTool
wrapper.This change forwards the properties introduced in #294, making them accessible at the LangChain integration layer. It is a key prerequisite for implementing self-authenticating tools (#291), as it allows higher-level abstractions to inspect a tool's auth needs directly.