-
Notifications
You must be signed in to change notification settings - Fork 24
fix!: fix auth_methods module #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhav756
previously approved these changes
Jul 16, 2025
anubhav756
approved these changes
Jul 17, 2025
kurtisvg
approved these changes
Jul 17, 2025
Merged
twishabansal
added a commit
to googleapis/genai-toolbox
that referenced
this pull request
Jul 18, 2025
github-actions bot
pushed a commit
to googleapis/genai-toolbox
that referenced
this pull request
Jul 18, 2025
… instances (#896) Corresponding to googleapis/mcp-toolbox-sdk-python#313 e5ac5ba
github-actions bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Jul 18, 2025
… instances (googleapis#896) Corresponding to googleapis/mcp-toolbox-sdk-python#313 e5ac5ba
AnujJhunjhunwala
pushed a commit
to AnujJhunjhunwala/genai-toolbox
that referenced
this pull request
Jul 18, 2025
AnujJhunjhunwala
pushed a commit
to AnujJhunjhunwala/genai-toolbox
that referenced
this pull request
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
get_google_id_token
andaget_google_id_token
methods to get google id token from google cloud environments.This code has been manually tested for the following cases:
Fixes googleapis/genai-toolbox#806, #311, #310
For personal accounts on local environments, users can keep using the existing code.
For other cases,
Before:
After