fix: Record grpc code string for client side metrics instead of grpc code number#1754
Merged
danieljbruce merged 9 commits intomainfrom Jan 8, 2026
Merged
Conversation
product-auto-label
bot
added
size: m
daniel-sanche
previously approved these changes
Jan 7, 2026
danieljbruce
added
the
automerge
danieljbruce
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
approved these changes
Jan 8, 2026
gcf-merge-on-green
bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For client side metrics, a string representing the grpc response should be recorded instead of the grpc code number. For example,
DEADLINE_EXCEEDEDshould be recorded instead of 4.Impact
Ensures that client side metrics get recorded in the proper format.
Testing
The test fixtures that define what data gets recorded have been updated to expect the grpc status in a string format.