Skip to content

Conversation

@tom-andersen
Copy link
Contributor

Fixes #2273

@tom-andersen tom-andersen requested review from a team as code owners January 6, 2025 21:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jan 6, 2025
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2025
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-andersen tom-andersen merged commit 1e714a8 into main Jan 7, 2025
17 checks passed
@tom-andersen tom-andersen deleted the tomandersen/fixRecusiveDeleteClose branch January 7, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db.terminate appears to detect BulkWriter leak from recursiveDelete

3 participants