Skip to content

fix: prevent crashes if an inactive stream receives an error. #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-hui merged 2 commits into from
Jan 21, 2025
Merged

fix: prevent crashes if an inactive stream receives an error. #2283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecbf9fc
fix: prevent crashes if an inactive stream receives an error.
ehsannas Jan 13, 2025
0d36740
Merge branch 'main' into ehsann/handle-error-after-end
ehsannas Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dev/src/watch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,12 @@ abstract class Watch<
'Closing inactive stream'
);
backendStream.emit('end');
backendStream.on('error', () => {
// Note that emitting 'end' above does not prevent the Duplex
// from receiving potential errors from the backend. Since the
// stream is no longer active (`isActive` is false), we
// swallow / ignore any errors it may receive.
});
return;
}
logger('Watch.initStream', this.requestTag, 'Opened new stream');
Expand Down
Loading