More expressions and API cleanup #2393
Merged
+3,613
−3,950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Also include @google-cloud/firestore/pipelines as an alternative submodule import
…gleapis/nodejs-firestore into markduckworth/pipeline-options
…rkduckworth/pipeline-options
…gleapis/nodejs-firestore into markduckworth/pipeline-options
…re into markduckworth/pipelines-subpackage
product-auto-label
bot
added
the
api: firestore
* feat: Add strReverse expression * Update order.ts revert jules' changes to compare ut8 strings test --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
* Fix reference parsing * Throw on parsing a reference to a collection or db root, until we define the SDK behavior. * Address pr feedback and other cleanup
…googleapis/nodejs-firestore into markduckworth/pipelines-new-expressions
…re into markduckworth/pipelines-new-expressions
…re into markduckworth/pipelines-new-expressions
MarkDuckworth
changed the title
* Renamed XWithAlias to AliasedX * API cleanup * rename generic to raw * API review - PipelineResult.data() should never return undefined * customOptions to rawOptions * custom to raw options * code cleanup * Fixes on reaname * API review fixes: PipelineExecuteOptions * API review: PipelineResult * Rename args to divide as dividend and divisor * Rename params to subtract * API audit * Remove @beta tag * Doc review start * enable all tests * TSDoc todos * Script/simple agent for updating tsdoc * Pipeline stream tests
wu-hui
reviewed
Aug 19, 2025
wu-hui
approved these changes
Aug 26, 2025
…googleapis/nodejs-firestore into markduckworth/pipelines-new-expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Missing expressions: concat, currentTimestamp, is, log10, mask, timestampTrunc