chore!: migrate to Node 18

.eslintrc.json

@@ -34,7 +34,8 @@
             "object": "it",
             "property": "only"
           }
-        ]
+        ],
+        "@typescript-eslint/no-floating-promises": ["off"]
       }
     }
   ]

.github/.OwlBot.lock.yaml

@@ -1,4 +1,4 @@
-# Copyright 2024 Google LLC
+# Copyright 2025 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -13,5 +13,4 @@
 # limitations under the License.
 docker:
   image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest
-  digest: sha256:0d39e59663287ae929c1d4ccf8ebf7cef9946826c9b86eda7e85d8d752dbb584
-# created: 2024-11-21T22:39:44.342569463Z
+  digest: sha256:ebf1487fdb5be0d02d49a20b01547be3cd15cbd03f4ded7b47c65eae7920a080

dev/conformance/runner.ts

@@ -70,15 +70,15 @@ protobufRoot.resolvePath = (origin, target) => {
   return target;
 };
 const protoDefinition = protobufRoot.loadSync(
-  path.join(__dirname, 'test-definition.proto')
+  path.join(__dirname, 'test-definition.proto'),
 );
 
 const TEST_SUITE_TYPE = protoDefinition.lookupType('tests.TestFile');
 const STRUCTURED_QUERY_TYPE = protoDefinition.lookupType(
-  'google.firestore.v1.StructuredQuery'
+  'google.firestore.v1.StructuredQuery',
 );
 const COMMIT_REQUEST_TYPE = protoDefinition.lookupType(
-  'google.firestore.v1.CommitRequest'
+  'google.firestore.v1.CommitRequest',
 );
 
 // Firestore instance initialized by the test runner.
@@ -128,11 +128,11 @@ const convertInput = {
     function convertArray(arr: unknown[]): unknown[] | FieldValue {
       if (arr.length > 0 && arr[0] === 'ArrayUnion') {
         return FieldValue.arrayUnion(
-          ...(convertArray(arr.slice(1)) as unknown[])
+          ...(convertArray(arr.slice(1)) as unknown[]),
         );
       } else if (arr.length > 0 && arr[0] === 'ArrayRemove') {
         return FieldValue.arrayRemove(
-          ...(convertArray(arr.slice(1)) as unknown[])
+          ...(convertArray(arr.slice(1)) as unknown[]),
         );
       } else {
         for (let i = 0; i < arr.length; ++i) {
@@ -183,8 +183,8 @@ const convertInput = {
       args.push(
         DocumentSnapshot.fromObject(
           docRef(cursor.docSnapshot.path),
-          convertInput.argument(cursor.docSnapshot.jsonData) as DocumentData
-        )
+          convertInput.argument(cursor.docSnapshot.jsonData) as DocumentData,
+        ),
       );
     } else {
       for (const jsonValue of cursor.jsonValues) {
@@ -205,8 +205,8 @@ const convertInput = {
         firestore.snapshot_(
           deepCopy,
           readTime.toDate().toISOString(),
-          'json'
-        ) as QueryDocumentSnapshot
+          'json',
+        ) as QueryDocumentSnapshot,
       );
     }
 
@@ -216,13 +216,13 @@ const convertInput = {
       const doc = firestore.snapshot_(
         deepCopy,
         readTime.toDate().toISOString(),
-        'json'
+        'json',
       ) as QueryDocumentSnapshot;
       const type = ['unspecified', 'added', 'removed', 'modified'][
         change.kind
       ] as DocumentChangeType;
       changes.push(
-        new DocumentChange(type, doc, change.oldIndex, change.newIndex)
+        new DocumentChange(type, doc, change.oldIndex, change.newIndex),
       );
     }
 
@@ -231,7 +231,7 @@ const convertInput = {
       readTime,
       docs.length,
       () => docs,
-      () => changes
+      () => changes,
     );
   },
 };
@@ -243,12 +243,12 @@ const convertProto = {
     const deepCopy = JSON.parse(JSON.stringify(listenRequest));
     if (deepCopy.targetChange) {
       deepCopy.targetChange.targetChangeType = convertProto.targetChange(
-        deepCopy.targetChange.targetChangeType
+        deepCopy.targetChange.targetChangeType,
       );
     }
     if (deepCopy.documentChange) {
       deepCopy.documentChange.document.fields = fieldsFromJson(
-        deepCopy.documentChange.document.fields
+        deepCopy.documentChange.document.fields,
       );
     }
     return deepCopy;
@@ -257,7 +257,7 @@ const convertProto = {
 
 /** Request handler for _commit. */
 function commitHandler(
-  spec: ConformanceProto
+  spec: ConformanceProto,
 ): UnaryMethod<api.ICommitRequest, api.ICommitResponse> {
   return request => {
     const actualCommit = COMMIT_REQUEST_TYPE.fromObject(request);
@@ -280,7 +280,7 @@ function commitHandler(
 function queryHandler(spec: ConformanceProto) {
   return (request: api.IRunQueryRequest) => {
     const actualQuery = STRUCTURED_QUERY_TYPE.fromObject(
-      request.structuredQuery!
+      request.structuredQuery!,
     );
     const expectedQuery = STRUCTURED_QUERY_TYPE.fromObject(spec.query);
     expect(actualQuery).to.deep.equal(expectedQuery);
@@ -407,7 +407,7 @@ function runTest(spec: ConformanceProto) {
       }
       return docRef(setSpec.docRefPath).set(
         convertInput.argument(spec.jsonData) as DocumentData,
-        setOption
+        setOption,
       );
     });
   };
@@ -416,7 +416,7 @@ function runTest(spec: ConformanceProto) {
     const overrides = {commit: commitHandler(spec)};
     return createInstance(overrides).then(() => {
       return docRef(spec.docRefPath).create(
-        convertInput.argument(spec.jsonData) as DocumentData
+        convertInput.argument(spec.jsonData) as DocumentData,
       );
     });
   };
@@ -445,7 +445,7 @@ function runTest(spec: ConformanceProto) {
                 !actualSnap.isEqual(convertInput.snapshot(expectedSnapshot))
               ) {
                 reject(
-                  new Error('Expected and actual snapshots do not match.')
+                  new Error('Expected and actual snapshots do not match.'),
                 );
               }
 
@@ -461,7 +461,7 @@ function runTest(spec: ConformanceProto) {
             expect(expectedSnapshots).to.have.length(0);
             unlisten();
             reject(err);
-          }
+          },
         );
 
         for (const response of spec.responses) {
@@ -515,7 +515,7 @@ function runTest(spec: ConformanceProto) {
       if (!testSpec.isError) {
         throw err;
       }
-    }
+    },
   );
 }
 

dev/src/aggregate.ts

@@ -29,7 +29,7 @@ export class Aggregate {
   constructor(
     readonly alias: string,
     readonly aggregateType: AggregateType,
-    readonly fieldPath?: string | FieldPath
+    readonly fieldPath?: string | FieldPath,
   ) {}
 
   /**
@@ -43,7 +43,7 @@ export class Aggregate {
     } else if (this.aggregateType === 'sum') {
       assert(
         this.fieldPath !== undefined,
-        'Missing field path for sum aggregation.'
+        'Missing field path for sum aggregation.',
       );
       proto.sum = {
         field: {
@@ -53,7 +53,7 @@ export class Aggregate {
     } else if (this.aggregateType === 'avg') {
       assert(
         this.fieldPath !== undefined,
-        'Missing field path for average aggregation.'
+        'Missing field path for average aggregation.',
       );
       proto.avg = {
         field: {
@@ -89,7 +89,7 @@ export class AggregateField<T> implements firestore.AggregateField<T> {
    */
   private constructor(
     public readonly aggregateType: AggregateType,
-    field?: string | FieldPath
+    field?: string | FieldPath,
   ) {
     this._field = field;
   }
@@ -112,7 +112,7 @@ export class AggregateField<T> implements firestore.AggregateField<T> {
         (this._field !== undefined &&
           other._field !== undefined &&
           FieldPath.fromArgument(this._field).isEqual(
-            FieldPath.fromArgument(other._field)
+            FieldPath.fromArgument(other._field),
           )))
     );
   }

dev/src/backoff.ts

@@ -72,7 +72,7 @@ export let delayExecution: (f: () => void, ms: number) => NodeJS.Timeout =
  * @param {function} handler A handler than matches the API of `setTimeout()`.
  */
 export function setTimeoutHandler(
-  handler: (f: () => void, ms: number) => void
+  handler: (f: () => void, ms: number) => void,
 ): void {
   delayExecution = (f: () => void, ms: number) => {
     handler(f, ms);
@@ -255,13 +255,13 @@ export class ExponentialBackoff {
   backoffAndWait(): Promise<void> {
     if (this.awaitingBackoffCompletion) {
       return Promise.reject(
-        new Error('A backoff operation is already in progress.')
+        new Error('A backoff operation is already in progress.'),
       );
     }
 
     if (this.retryCount > MAX_RETRY_ATTEMPTS) {
       return Promise.reject(
-        new Error('Exceeded maximum number of retries allowed.')
+        new Error('Exceeded maximum number of retries allowed.'),
       );
     }
     // First schedule using the current base (which may be 0 and should be
@@ -272,7 +272,7 @@ export class ExponentialBackoff {
         'ExponentialBackoff.backoffAndWait',
         null,
         `Backing off for ${delayWithJitterMs} ms ` +
-          `(base delay: ${this.currentBaseMs} ms)`
+          `(base delay: ${this.currentBaseMs} ms)`,
       );
     }