Skip to content

chore: bump node 14 to node 18 in kokoro #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

chore: bump node 14 to node 18 in kokoro #2417

merged 1 commit into from
Sep 12, 2025

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 12, 2025 •
edited
Loading

The warning below highlights that these changes should be done via synthtool. But I don't know how to use that tool and I just need to get the presubmits working. So I'm going to try to merge this PR anyways and we can deal with synthtool some other day.

@generated-files-bot
Copy link

generated-files-bot bot commented Sep 12, 2025

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.bat - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Sep 12, 2025
@dconeybe dconeybe added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2025
@dconeybe dconeybe marked this pull request as ready for review September 12, 2025 13:37
@dconeybe dconeybe requested review from a team as code owners September 12, 2025 13:37
@MarkDuckworth
Copy link
Contributor

MarkDuckworth commented Sep 12, 2025

This is the same issue affecting #2399. Thanks for looking into it. This comment suggests that the files should be generated by owlbot/synth tool, but our owlbot post processor (in owlbot.py) is excluding these files.

MarkDuckworth
MarkDuckworth approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to merge if we want to unblock for a quick release. I'm also looking into the fix for our owlbot post processor.

@dconeybe dconeybe merged commit c7ee682 into main Sep 12, 2025
19 checks passed
@dconeybe dconeybe deleted the dconeybe/node18 branch September 12, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @MarkDuckworth