Skip to content

feat: add required messaging.operation span attrs for OTel sem convs 1.24 #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feywind merged 3 commits into from
Mar 27, 2025
Merged

feat: add required messaging.operation span attrs for OTel sem convs 1.24 #2019

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a3ded9
Add required messaging.operation span attrs for OTel sem convs 1.31
amychisholm03 Mar 25, 2025
a215452
fix: Use 1.24 instead of 1.31 as it's not stable
amychisholm03 Mar 26, 2025
71bd424
Merge branch 'main' into otel-sem-convs-1_31
feywind Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/telemetry-tracing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export class PubsubSpans {

const spanAttributes = {
// Add Opentelemetry semantic convention attributes to the span, based on:
// https://github.com/open-telemetry/opentelemetry-specification/blob/v1.1.0/specification/trace/semantic_conventions/messaging.md
// https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/messaging/messaging-spans.md
['messaging.system']: 'gcp_pubsub',
['messaging.destination.name']: destinationId ?? destinationName,
['gcp.project_id']: projectId,
Expand Down Expand Up @@ -396,6 +396,7 @@ export class PubsubSpans {
});
if (topicInfo.topicId) {
span.updateName(`${topicInfo.topicId} create`);
span.setAttribute('messaging.operation', 'create');
span.setAttribute('messaging.destination.name', topicInfo.topicId);
}

Expand Down Expand Up @@ -430,6 +431,7 @@ export class PubsubSpans {
const attributes = this.createAttributes(subInfo, message, caller);
if (subInfo.subId) {
attributes['messaging.destination.name'] = subInfo.subId;
attributes['messaging.operation'] = 'receive';
}

if (context) {
Expand Down Expand Up @@ -553,6 +555,7 @@ export class PubsubSpans {
);

span?.setAttribute('messaging.batch.message_count', messageSpans.length);
span?.setAttribute('messaging.operation', 'receive');

if (span) {
// Also attempt to link from the subscribe span(s) back to the publish RPC span.
Expand Down Expand Up @@ -600,6 +603,7 @@ export class PubsubSpans {
);

span?.setAttribute('messaging.batch.message_count', messageSpans.length);
span?.setAttribute('messaging.operation', 'receive');

if (span) {
// Also attempt to link from the subscribe span(s) back to the publish RPC span.
Expand Down Expand Up @@ -651,7 +655,7 @@ export class PubsubSpans {
}

static setReceiveProcessResult(span: Span, isAck: boolean) {
span.setAttribute('messaging.gcp_pubsub.result', isAck ? 'ack' : 'nack');
span?.setAttribute('messaging.gcp_pubsub.result', isAck ? 'ack' : 'nack');
}
}

Expand Down