Skip to content

chore!: migrate to Node 18 #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feywind merged 25 commits into from
Apr 28, 2025
Merged

chore!: migrate to Node 18 #2024

feywind merged 25 commits into from
Apr 28, 2025

Conversation

@feywind
Copy link
Collaborator

@feywind feywind commented Apr 14, 2025 •
edited
Loading

Does the following:

  • Update minimum engines to 18
  • Upgrades package versions as far as possible without hitting esm modules or >18 reqs
  • Fixes dangling promises where simple, adds void to others to keep stuff going
  • A ton of linter changes for trailing commas in parameter lists (the vast majority of the changes)
  • Fully moves typeless-bot support out of the OwlBot process; run by hand
  • Updates gapic (autogen) classes from latest generator version
  • Also, due to the above, adds gapic-level debug logging support

A couple of breaking changes for Pub/Sub code will be coming shortly as well, nothing major. (Well, major version major, not changes required major :) )

  • Remove (broken) legacy OTel support
  • Remove legacy ack deadline options, and move maxExtension into subscriber options

@generated-files-bot
Copy link

generated-files-bot bot commented Apr 14, 2025 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.bat - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool
  • README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 14, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 14, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2025
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 22, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 22, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2025
@feywind feywind marked this pull request as ready for review April 25, 2025 21:10
@feywind feywind requested review from a team as code owners April 25, 2025 21:10
@feywind
Copy link
Collaborator Author

feywind commented Apr 25, 2025

@hongalex ty! I'm going to wait for a Node person to take a look too.

sofisl
sofisl approved these changes Apr 25, 2025
View reviewed changes
@sofisl sofisl self-requested a review April 25, 2025 21:34
@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 25, 2025
@feywind
Copy link
Collaborator Author

feywind commented Apr 25, 2025

@sofisl I'll put a DNM label on this so it doesn't get auto-merged over the weekend or whatever, until I can look at your comments.

@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Apr 28, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@feywind feywind merged commit 9ad808a into main Apr 28, 2025
18 checks passed
@feywind feywind deleted the node18 branch April 28, 2025 20:36
@release-please release-please bot mentioned this pull request Apr 28, 2025
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 28, 2025
@release-please
chore(main): release 5.0.0 (#2031)
4108a69 
🤖 I have created a release *beep* *boop*
---


## [5.0.0](https://togithub.com/googleapis/nodejs-pubsub/compare/v4.11.0...v5.0.0) (2025-04-28)


### ⚠ BREAKING CHANGES

* migrate to Node 18 ([#2024](https://togithub.com/googleapis/nodejs-pubsub/issues/2024))
* remove (broken) legacy OTel support
* remove legacy ack deadline options
* move maxExtension into subscriber options

### Miscellaneous Chores

* Migrate to Node 18 ([#2024](https://togithub.com/googleapis/nodejs-pubsub/issues/2024)) ([9ad808a](https://togithub.com/googleapis/nodejs-pubsub/commit/9ad808adb99b6e64c2c4431991721deae14b6400))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@feywind feywind mentioned this pull request Apr 30, 2025
Closed
@AlessandroSteri AlessandroSteri mentioned this pull request Jun 10, 2025
Open
7 tasks
@nzws nzws mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongalex hongalex hongalex approved these changes

@sofisl sofisl sofisl approved these changes

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@feywind @hongalex @sofisl @yoshi-kokoro