-
Notifications
You must be signed in to change notification settings - Fork 233
fix: updated span kind to CLIENT for ack and modack rpc spans #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@bizob2828 Thanks for the PR! Let me run this by my OTel collaborator here. |
|
@bizob2828 Hey would you mind running |
|
@feywind I ran |
…ook at that in a separate PR if it's problematic
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2028 🦕
This PR updates the span kind based on the unary pull example to set span kind to client for modack/ack spans. I also added some missing assertions from #2019