Skip to content
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
24c37bb
feat: Add timeout option to Subscription.close()
google-labs-jules[bot] May 6, 2025
687212d
docs: revert README change so release-please can do it
feywind May 9, 2025
da726d0
feat: jules' vibin' is too lo-fi, fix some bad assumptions
feywind May 13, 2025
629aa43
samples: typeless a JS sample for close with timeout
feywind May 13, 2025
a0ba234
feat: add awaitWithTimeout and test
feywind Jun 16, 2025
13e58f2
tests: also test error results without timeout
feywind Jun 16, 2025
5db179e
feat: update for the current spec, test updates coming
feywind Jun 16, 2025
62afe56
tests: misc fixes before further additions
feywind Jun 19, 2025
b904884
feat: update Temporal shims to match latest standards
feywind Jun 20, 2025
2cf219f
chore: linter fix
feywind Jun 20, 2025
6e41e4d
feat: update to latest spec doc info, finish unit tests
feywind Jun 20, 2025
49003e9
Merge branch 'main' into feat-close-timeout
feywind Jun 20, 2025
ca50c3c
feat: also move the options from close() parameters to subscriber opt…
feywind Jun 20, 2025
ce5e917
chore: fix linter errors
feywind Jul 4, 2025
f2898a3
samples: update to latest API changes
feywind Jul 8, 2025
073c6d7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 3, 2025
bcad5e7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 16, 2025
f28be03
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 16, 2025
9aabe08
Merge branch 'feat-close-timeout' of https://github.com/googleapis/no…
gcf-owl-bot[bot] Jul 16, 2025
8866c98
fix: no need to check isEmpty on remove
feywind Aug 6, 2025
82e0c81
chore: merge remote-tracking branch 'refs/remotes/origin/feat-close-t…
feywind Aug 6, 2025
f08ae6d
chore: merge remote-tracking branch 'remotes/origin/main' into feat-c…
feywind Aug 6, 2025
791a7f0
chore: remove unneeded promise skip code
feywind Aug 6, 2025
36e5361
fix: substantially clarify the awaitWithTimeout interface
feywind Aug 6, 2025
d3a3489
chore: hoist timeout logic into its own method
feywind Aug 6, 2025
a285935
fix: tests were leaking EventEmitter handlers
feywind Aug 6, 2025
abeeb6c
chore: change constant to CONSTANT_CASE
feywind Aug 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ Samples are in the [`samples/`](https://github.com/googleapis/nodejs-pubsub/tree

| Sample | Source Code | Try it |
| --------------------------- | --------------------------------- | ------ |
| Close Subscription with Timeout | [source code](https://github.com/googleapis/nodejs-pubsub/blob/main/samples/closeSubscriptionWithTimeout.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-pubsub&page=editor&open_in_editor=samples/closeSubscriptionWithTimeout.js,samples/README.md) |
| Commit an Avro-Based Schema | [source code](https://github.com/googleapis/nodejs-pubsub/blob/main/samples/commitAvroSchema.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-pubsub&page=editor&open_in_editor=samples/commitAvroSchema.js,samples/README.md) |
| Commit an Proto-Based Schema | [source code](https://github.com/googleapis/nodejs-pubsub/blob/main/samples/commitProtoSchema.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-pubsub&page=editor&open_in_editor=samples/commitProtoSchema.js,samples/README.md) |
| Create an Avro based Schema | [source code](https://github.com/googleapis/nodejs-pubsub/blob/main/samples/createAvroSchema.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-pubsub&page=editor&open_in_editor=samples/createAvroSchema.js,samples/README.md) |
Expand Down
522 changes: 518 additions & 4 deletions protos/protos.d.ts

Large diffs are not rendered by default.

1,821 changes: 1,747 additions & 74 deletions protos/protos.js

Large diffs are not rendered by default.

Loading
Loading