Skip to content

fix: rpcSpan closure logic in message-queues #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n3xt-alexy wants to merge 1 commit into from
+5 −4
Closed

fix: rpcSpan closure logic in message-queues #2120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/publisher/message-queues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,11 @@ export abstract class MessageQueue extends EventEmitter {

throw e;
} finally {
messages.forEach(m => {
// We're finished with both the RPC and the whole publish operation,
// so close out all of the related spans.
rpcSpan?.end();
// We're finished with both the RPC and the whole publish operation,
// so close out all of the related spans.
// rpcSpan must be closed only once
rpcSpan?.end();
messages.forEach(m => {
tracing.PubsubEvents.publishEnd(m);
m.parentSpan?.end();
});
Expand Down
Loading