Skip to content

fix(deps): update dependency protobufjs to v8 #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deps): update dependency protobufjs to v8 #2491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"lodash.snakecase": "^4.1.1",
"merge-stream": "^2.0.0",
"p-queue": "^6.0.2",
"protobufjs": "^7.4.0",
"protobufjs": "^8.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This major version upgrade to protobufjs v8 introduces a breaking change related to Protobuf Edition 2024. This change alters default feature values for .proto files that use edition = "2024". This could lead to unexpected behavior if the project adopts Edition 2024 in the future or if any transitive dependency relies on the old defaults. Given the nature of this change, there's a risk of introducing subtle bugs in serialization/deserialization logic.

"retry-request": "^8.0.0",
"split-array-stream": "^2.0.0",
"stack-trace": "0.0.10",
Expand Down
2 changes: 1 addition & 1 deletion samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@google-cloud/kms": "^5.0.0",
"@google-cloud/precise-date": "^5.0.0",
"@google-cloud/spanner": "^8.4.0",
"protobufjs": "^7.0.0",
"protobufjs": "^8.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This major version upgrade of protobufjs to v8 introduces a breaking change related to Protobuf Edition 2024. This could affect the samples if they rely on specific protobuf behaviors that have now changed for the new edition. There's a risk of the samples failing or behaving unexpectedly due to this change.

"yargs": "^17.0.0"
},
"devDependencies": {
Expand Down
Loading