Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ Samples are in the [`samples/`](https://github.com/googleapis/nodejs-spanner/tre
| Quickstart | [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/quickstart.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-spanner&page=editor&open_in_editor=samples/quickstart.js,samples/README.md) |
| Read data with database role | [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/read-data-with-database-role.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-spanner&page=editor&open_in_editor=samples/read-data-with-database-role.js,samples/README.md) |
| Performs a read-write transaction with isolation level option | [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/repeatable-reads.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-spanner&page=editor&open_in_editor=samples/repeatable-reads.js,samples/README.md) |
| Performs a read-write transaction with read lock mode option | [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/read-lock-mode.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-spanner&page=editor&open_in_editor=samples/read-lock-mode.js,samples/README.md) |
| Sets a request tag for a single query | [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/request-tag.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-spanner&page=editor&open_in_editor=samples/request-tag.js,samples/README.md) |
| Run Batch update with RPC priority | [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/rpc-priority-batch-dml.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-spanner&page=editor&open_in_editor=samples/rpc-priority-batch-dml.js,samples/README.md) |
| Run partitioned update with RPC priority | [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/rpc-priority-partitioned-dml.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-spanner&page=editor&open_in_editor=samples/rpc-priority-partitioned-dml.js,samples/README.md) |
Expand Down
18 changes: 18 additions & 0 deletions samples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ and automatic, synchronous replication for high availability.
* [Quickstart](#quickstart)
* [Read data with database role](#read-data-with-database-role)
* [Performs a read-write transaction with isolation level option](#performs-a-read-write-transaction-with-isolation-level-option)
* [Performs a read-write transaction with read lock mode option](#performs-a-read-write-transaction-with-read-lock-mode-option)
* [Sets a request tag for a single query](#sets-a-request-tag-for-a-single-query)
* [Run Batch update with RPC priority](#run-batch-update-with-rpc-priority)
* [Run partitioned update with RPC priority](#run-partitioned-update-with-rpc-priority)
Expand Down Expand Up @@ -1906,6 +1907,23 @@ __Usage:__



### Performs a read-write transaction with read lock mode option

View the [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/read-lock-mode.js).

[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-spanner&page=editor&open_in_editor=samples/read-lock-mode.js,samples/README.md)

__Usage:__


`node read-lock-mode.js <INSTANCE_ID> <DATABASE_ID> <PROJECT_ID>`


-----




Comment on lines +1917 to +1926

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are some extra newlines here that make the formatting inconsistent with the rest of the file. Please remove the extra blank lines for consistency.

Suggested change
`node read-lock-mode.js <INSTANCE_ID> <DATABASE_ID> <PROJECT_ID>`
-----
`node read-lock-mode.js <INSTANCE_ID> <DATABASE_ID> <PROJECT_ID>`
-----

### Sets a request tag for a single query

View the [source code](https://github.com/googleapis/nodejs-spanner/blob/main/samples/request-tag.js).
Expand Down
100 changes: 100 additions & 0 deletions samples/read-lock-mode.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
// Copyright 2026 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

// sample-metadata:
// title: Performs a read-write transaction with read lock mode option
// usage: node read-lock-mode.js <INSTANCE_ID> <DATABASE_ID> <PROJECT_ID>

'use strict';

function main(
instanceId = 'my-instance',
databaseId = 'my-database',
projectId = 'my-project-id',
) {
// [START spanner_read_lock_mode]
// Imports the Google Cloud Spanner client library
const {Spanner, protos} = require('@google-cloud/spanner');
// The read lock mode specified at the client-level will be applied
// to all RW transactions.
const readLockModeOptionsForClient = {
defaultTransactionOptions: {
readLockMode:
protos.google.spanner.v1.TransactionOptions.ReadWrite.ReadLockMode
.OPTIMISTIC,
},
};

// Instantiates a client with defaultTransactionOptions
const spanner = new Spanner({
projectId: projectId,
defaultTransactionOptions: readLockModeOptionsForClient,
});
Comment on lines +31 to +43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The defaultTransactionOptions object is nested incorrectly. It should be a flat object at the top level of the Spanner constructor options, not nested within another defaultTransactionOptions property. This prevents the client-level readLockMode from being applied.

  const defaultTransactionOptions = {
    readLockMode:
      protos.google.spanner.v1.TransactionOptions.ReadWrite.ReadLockMode
        .OPTIMISTIC,
  };

  // Instantiates a client with defaultTransactionOptions
  const spanner = new Spanner({
    projectId: projectId,
    defaultTransactionOptions,
  });


function runTransactionWithReadLockMode() {
// Gets a reference to a Cloud Spanner instance and database
const instance = spanner.instance(instanceId);
const database = instance.database(databaseId);
// The read lock mode specified at the request-level takes precedence over
// the read lock mode configured at the client-level.
const readLockModeOptionsForTransaction = {
readLockMode:
protos.google.spanner.v1.TransactionOptions.ReadWrite.ReadLockMode
.PESSIMISTIC,
};

database.runTransaction(
readLockModeOptionsForTransaction,
async (err, transaction) => {
if (err) {
console.error(err);
return;
}
try {
const query =
'SELECT AlbumTitle FROM Albums WHERE SingerId = 2 AND AlbumId = 1';
const results = await transaction.run(query);
// Gets first album's title
const rows = results[0].map(row => row.toJSON());
const albumTitle = rows[0].AlbumTitle;
console.log(`previous album title ${albumTitle}`);

const update =
"UPDATE Albums SET AlbumTitle = 'New Album Title' WHERE SingerId = 2 AND AlbumId = 1";
const [rowCount] = await transaction.runUpdate(update);
console.log(
`Successfully updated ${rowCount} record in Albums table.`,
);
await transaction.commit();
console.log(
'Successfully executed read-write transaction with readLockMode option.',
);
} catch (err) {
console.error('ERROR:', err);
} finally {
transaction.end();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The database.runTransaction() method automatically handles session management, including releasing the session when the transaction is complete. Calling transaction.end() here is redundant and should be removed for clarity and to avoid potential issues with double-releasing sessions.

// Close the database when finished.
await database.close();
}
},
);
}
runTransactionWithReadLockMode();
// [END spanner_read_lock_mode]
}
process.on('unhandledRejection', err => {
console.error(err.message);
process.exitCode = 1;
});
main(...process.argv.slice(2));
18 changes: 18 additions & 0 deletions samples/system-test/spanner.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1322,6 +1322,24 @@ describe('Autogenerated Admin Clients', () => {
);
});

// read_lock_mode_option
it('should run read-write transaction with read lock mode option set', () => {
const output = execSync(
`node read-lock-mode.js ${INSTANCE_ID} ${DATABASE_ID} ${PROJECT_ID}`,
);
assert.match(output, new RegExp('previous album title Total Junk'));
assert.match(
output,
new RegExp('Successfully updated 1 record in Albums table.'),
);
assert.match(
output,
new RegExp(
'Successfully executed read-write transaction with readLockMode option.',
),
);
});

// add_and_drop_new_database_role
it('should add and drop new database roles', async () => {
const output = execSync(
Expand Down
Loading