chore: implement eq, eq_null_match, ne compilers #2008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
sycai
reviewed
Aug 20, 2025
| @@ -163,3 +175,16 @@ def _(op, left: TypedExpr, right: TypedExpr) -> sge.Expression: | |||
| @BINARY_OP_REGISTRATION.register(ops.obj_make_ref_op) | |||
| def _(op, left: TypedExpr, right: TypedExpr) -> sge.Expression: | |||
| return sge.func("OBJ.MAKE_REF", left.expr, right.expr) | |||
|
|
|||
|
|
|||
| def _coerce_bools( | |||
There was a problem hiding this comment.
This parameter design choice is a little weird. Suggestion:
let's create a "_coerce_bool_to_int" function that process one value at a time.
Then at callsite, we could
left_expr = _coerce_bool_to_int(left.expr)
right_expr = _coerce_bool_to_int(right.expr)
There was a problem hiding this comment.
Good points. I added coerce_bool_to_int and coerce_date_to_datetime to the TypedExpr class.
There was a problem hiding this comment.
Thanks! Could we make them top-level functions instead of class method?
I generally expect methods like TypedExpr.to_abc() to still return a TypedExpr value, which might make our code more verbose. Top-level functions feel like a better choice.
There was a problem hiding this comment.
Makes sense to me. Thanks!
chelsea-lin
force-pushed
the
main_chelsealin_eq0
branch
from
621bbf0 to
9d96811
Compare
chelsea-lin
force-pushed
the
main_chelsealin_eq0
branch
from
9d96811 to
31814df
Compare
product-auto-label
bot
added
size: l
chelsea-lin
force-pushed
the
main_chelsealin_eq0
branch
from
31814df to
0950b01
Compare
sycai
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 430133370 🦕