Skip to content

chore: Migrate BinaryRemoteFunctionOp operator to SQLGlot #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jialuoo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Migrate BinaryRemoteFunctionOp operator to SQLGlot #2371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
926a9af
chore: Migrate BinaryRemoteFunctionOp operator to SQLGlot
jialuoo Jan 8, 2026
e8e0ce5
add backtick
jialuoo Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bigframes/core/compile/sqlglot/expressions/generic_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,13 @@ def _(left: TypedExpr, right: TypedExpr) -> sge.Expression:
return sge.Coalesce(this=left.expr, expressions=[right.expr])


@register_binary_op(ops.BinaryRemoteFunctionOp, pass_op=True)
def _(
left: TypedExpr, right: TypedExpr, op: ops.BinaryRemoteFunctionOp
) -> sge.Expression:
return sge.func(str(op.function_def.routine_ref), left.expr, right.expr)


@register_nary_op(ops.case_when_op)
def _(*cases_and_outputs: TypedExpr) -> sge.Expression:
# Need to upcast BOOL to INT if any output is numeric
Expand Down
14 changes: 14 additions & 0 deletions ...ile/sqlglot/expressions/snapshots/test_generic_ops/test_binary_remote_function_op/out.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
WITH `bfcte_0` AS (
SELECT
`float64_col`,
`int64_col`
FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
), `bfcte_1` AS (
SELECT
*,
my_project.my_dataset.my_routine(`int64_col`, `float64_col`) AS `bfcol_2`
Copy link
Contributor

@chelsea-lin chelsea-lin Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting the routine_ref can prevent clashes with reserved keywords. This can be done by calling sge.to_identifier("a_string", quoted=True). The expected SQL would be like

`my_project`.`my_dataset`.`my_routine`

Copy link
Contributor Author

@jialuoo jialuoo Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backtick added. Thanks.

FROM `bfcte_0`
)
SELECT
`bfcol_2` AS `int64_col`
FROM `bfcte_1`
37 changes: 37 additions & 0 deletions tests/unit/core/compile/sqlglot/expressions/test_generic_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,43 @@ def test_astype_json_invalid(
)


def test_binary_remote_function_op(scalar_types_df: bpd.DataFrame, snapshot):
from google.cloud import bigquery

from bigframes.functions import udf_def

bf_df = scalar_types_df[["int64_col", "float64_col"]]
op = ops.BinaryRemoteFunctionOp(
function_def=udf_def.BigqueryUdf(
routine_ref=bigquery.RoutineReference.from_string(
"my_project.my_dataset.my_routine"
),
signature=udf_def.UdfSignature(
input_types=(
udf_def.UdfField(
"x",
bigquery.StandardSqlDataType(
type_kind=bigquery.StandardSqlTypeNames.INT64
),
),
udf_def.UdfField(
"y",
bigquery.StandardSqlDataType(
type_kind=bigquery.StandardSqlTypeNames.FLOAT64
),
),
),
output_bq_type=bigquery.StandardSqlDataType(
type_kind=bigquery.StandardSqlTypeNames.FLOAT64
),
),
)
)
sql = utils._apply_binary_op(bf_df, op, "int64_col", "float64_col")

snapshot.assert_match(sql, "out.sql")


def test_case_when_op(scalar_types_df: bpd.DataFrame, snapshot):
ops_map = {
"single_case": ops.case_when_op.as_expr(
Expand Down
Loading