Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Dec 17, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 384564457
🦕

@tswast tswast requested review from a team as code owners December 17, 2024 21:59
@tswast tswast requested review from shobsi and shollyman December 17, 2024 21:59
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Dec 17, 2024
@tswast tswast merged commit 03fe1d5 into main Dec 17, 2024
23 of 24 checks passed
@tswast tswast deleted the b384564457-bqsql branch December 17, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants