Skip to content

fix!: to_gbq uploads ArrowDtype(pa.timestamp(...) without timezone as DATETIME type #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix!: to_gbq uploads ArrowDtype(pa.timestamp(...) without timezone as DATETIME type #832

merged 2 commits into from
Dec 11, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Dec 10, 2024 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
fix!: to_gbq uploads ArrowDtype(pa.timestamp(...) without timezone as DATETIME type (#832)

Needed to support bigframes in googleapis/python-bigquery-dataframes#371, which uses ArrowDtype to represent DATETIME and TIMESTAMP columns.

Release-As: 0.25.0
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #450
🦕

@tswast tswast requested review from a team as code owners December 10, 2024 19:01
@tswast tswast requested a review from leahecole December 10, 2024 19:01
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 10, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Dec 10, 2024
@tswast tswast mentioned this pull request Dec 10, 2024
Merged
4 tasks
@Linchin Linchin assigned Linchin and unassigned chelsea-lin Dec 11, 2024
@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 11, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 11, 2024
Linchin
Linchin approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@tswast tswast merged commit 2104b71 into main Dec 11, 2024
27 checks passed
@tswast tswast deleted the issue450-datetime-arrowdtype branch December 11, 2024 15:50
@release-please release-please bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchin Linchin Linchin approved these changes

@leahecole leahecole Awaiting requested review from leahecole leahecole is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@Linchin Linchin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

append to table with DATETIME column with generated schema
4 participants
@tswast @Linchin @yoshi-kokoro @chelsea-lin