Skip to content

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jul 31, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 31, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 6, 2025
Towards internal issue b/409104302
@tswast tswast marked this pull request as ready for review August 13, 2025 19:33
@tswast tswast requested review from a team as code owners August 13, 2025 19:33
@tswast tswast requested review from chalmerlowe and Linchin August 13, 2025 19:34
@tswast
Copy link
Contributor Author

tswast commented Aug 14, 2025

Type failures:

nox > mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/
google/cloud/bigquery/external_config.py:894: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
samples/client_query_batch.py:47: error: Argument 1 to "get_job" of "Client" has incompatible type "Optional[str]"; expected "Union[str, LoadJob, CopyJob, ExtractJob, QueryJob]"  [arg-type]
samples/tests/test_create_job.py:28: error: Argument 1 to "cancel_job" of "Client" has incompatible type "Optional[str]"; expected "str"  [arg-type]
samples/tests/test_client_list_jobs.py:29: error: Argument 1 to "cancel_job" of "Client" has incompatible type "Optional[str]"; expected "str"  [arg-type]
Found 3 errors in 3 files (checked 244 source files)
nox > Command mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/ failed with exit code 1
nox > Session mypy_samples failed

I didn't touch these samples or get_job / cancel_job, so these seem unrelated.

Edit: Actually, I did add some type annotations where they were missing before. I'll see what needs to change.

Edit2: Fixed! I reverted the type annotations changes for now.

Comment on lines 599 to 601
# TODO(tswast): After
# https://github.com/googleapis/python-bigquery/pull/2260 goes in, add
# created, started, ended properties here.
Copy link
Collaborator

@chalmerlowe chalmerlowe Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#BLOCK

PR #2260 is merged.
Please resolve the #TODO here and throughout the code (It shows up multiple times.)

Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two blockers:

  • It appears that a #TODO comment that appears multiple times in multiple files is no longer needed. Please resolve throughout the PR.
  • There is word that has been incorrectly spelled (~ five times), please resolve.

Beyond that, this LGTM.
Hit me up as soon as these changes are made and I will Approve.
*

"totalBytesProcessed": "123",
"totalSlotMs": "987",
"jobComplete": True,
# TODO(tswast): After
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#BLOCK

Please resolve #TODO comment throughout this file (there are at least two references). PR 2260 is merged.

Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast enabled auto-merge (squash) August 18, 2025 15:29
@tswast tswast merged commit 6659355 into main Aug 18, 2025
34 of 42 checks passed
@tswast tswast deleted the tswast-bigframes branch August 18, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants