Skip to content

chore(tests): re-enable pipeline system tests on kokoro #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-sanche merged 9 commits into from
Jan 13, 2026
Merged

chore(tests): re-enable pipeline system tests on kokoro #1153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c3532fb
chore(tests): re-enable pipeline system tests on kokoro
daniel-sanche Jan 13, 2026
fcab87d
re-enable tests in pipeline_acceptance
daniel-sanche Jan 13, 2026
254f555
updated db name
daniel-sanche Jan 13, 2026
49e7ee9
fixed lint
daniel-sanche Jan 13, 2026
15d8595
re-trigger CI
daniel-sanche Jan 13, 2026
29f57ef
removed index_mode
daniel-sanche Jan 13, 2026
a512cf7
fixed index mode in results
daniel-sanche Jan 13, 2026
4bc4cbb
fixed unit test
daniel-sanche Jan 13, 2026
c036348
removed index_mode
daniel-sanche Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/system/test__helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,3 @@
# run all tests against default database, and a named database
TEST_DATABASES = [None, FIRESTORE_OTHER_DB]
TEST_DATABASES_W_ENTERPRISE = TEST_DATABASES + [FIRESTORE_ENTERPRISE_DB]
# TODO remove when kokoro fully supports enterprise mode/pipelines
IS_KOKORO_TEST = os.getenv("KOKORO_JOB_NAME") is not None
11 changes: 0 additions & 11 deletions tests/system/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
ENTERPRISE_MODE_ERROR,
TEST_DATABASES,
TEST_DATABASES_W_ENTERPRISE,
IS_KOKORO_TEST,
FIRESTORE_ENTERPRISE_DB,
)

Expand All @@ -69,10 +68,6 @@ def _get_credentials_and_project():
def database(request):
from test__helpers import FIRESTORE_ENTERPRISE_DB

# enterprise mode currently does not support RunQuery calls in prod on kokoro test project
# TODO: remove skip when kokoro test project supports full enterprise mode
if request.param == FIRESTORE_ENTERPRISE_DB and IS_KOKORO_TEST:
pytest.skip("enterprise mode does not support RunQuery on kokoro")
return request.param


Expand Down Expand Up @@ -101,11 +96,6 @@ def verify_pipeline(query):
"""
from google.cloud.firestore_v1.base_aggregation import BaseAggregationQuery

# return early on kokoro. Test project doesn't currently support pipelines
# TODO: enable pipeline verification when kokoro test project is whitelisted
if IS_KOKORO_TEST:
pytest.skip("skipping pipeline verification on kokoro")

def _clean_results(results):
if isinstance(results, dict):
return {k: _clean_results(v) for k, v in results.items()}
Expand Down Expand Up @@ -1825,7 +1815,6 @@ def test_query_stream_w_read_time(query_docs, cleanup, database):
assert new_values[new_ref.id] == new_data


@pytest.mark.skipif(IS_KOKORO_TEST, reason="skipping pipeline verification on kokoro")
@pytest.mark.parametrize("database", [FIRESTORE_ENTERPRISE_DB], indirect=True)
def test_pipeline_w_read_time(query_docs, cleanup, database):
collection, stored, allowed_vals = query_docs
Expand Down
11 changes: 0 additions & 11 deletions tests/system/test_system_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
ENTERPRISE_MODE_ERROR,
TEST_DATABASES,
TEST_DATABASES_W_ENTERPRISE,
IS_KOKORO_TEST,
FIRESTORE_ENTERPRISE_DB,
)

Expand Down Expand Up @@ -147,10 +146,6 @@ def _verify_explain_metrics_analyze_false(explain_metrics):
def database(request):
from test__helpers import FIRESTORE_ENTERPRISE_DB

# enterprise mode currently does not support RunQuery calls in prod on kokoro test project
# TODO: remove skip when kokoro test project supports full enterprise mode
if request.param == FIRESTORE_ENTERPRISE_DB and IS_KOKORO_TEST:
pytest.skip("enterprise mode does not support RunQuery on kokoro")
return request.param


Expand Down Expand Up @@ -181,11 +176,6 @@ async def verify_pipeline(query):
"""
from google.cloud.firestore_v1.base_aggregation import BaseAggregationQuery

# return early on kokoro. Test project doesn't currently support pipelines
# TODO: enable pipeline verification when kokoro test project is whitelisted
if IS_KOKORO_TEST:
pytest.skip("skipping pipeline verification on kokoro")

def _clean_results(results):
if isinstance(results, dict):
return {k: _clean_results(v) for k, v in results.items()}
Expand Down Expand Up @@ -1694,7 +1684,6 @@ async def test_pipeline_explain_options_using_additional_options(
assert "Execution:" in text_stats


@pytest.mark.skipif(IS_KOKORO_TEST, reason="skipping pipeline verification on kokoro")
@pytest.mark.parametrize("database", [FIRESTORE_ENTERPRISE_DB], indirect=True)
async def test_pipeline_w_read_time(query_docs, cleanup, database):
collection, stored, allowed_vals = query_docs
Expand Down