Skip to content

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Dec 19, 2025

chore: skip kms tests until b/470276398

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Dec 19, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces temporary modifications to the test suite to skip specific Key Management Service (KMS) related tests when executed under Python 3.14. This measure is a workaround for an identified issue, referenced as 'b/470276398', ensuring the test suite remains stable on newer Python versions while the root cause is investigated and resolved.

Highlights

  • Conditional Test Skipping: Several Key Management Service (KMS) related tests are now conditionally skipped.
  • Python 3.14 Specific: The test skips are specifically applied when the test suite is run on Python 3.14.
  • Issue Reference: The reason for skipping these tests references an internal issue tracker ID, 'b/470276398'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to temporarily disable several KMS-related tests when running on Python 3.14, due to an underlying issue. The approach of using pytest.mark.skipif is appropriate. However, there is a critical issue in the implementation of the Python version check that will prevent the tests from being skipped as intended. I have provided a specific comment with a code suggestion to correct this.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@chandra-siri chandra-siri changed the title skip kms tests unitll b/470276398 chore: skip kms tests unitl b/470276398 Dec 19, 2025
@chandra-siri chandra-siri changed the title chore: skip kms tests unitl b/470276398 chore: skip kms tests until b/470276398 Dec 19, 2025
@chandra-siri chandra-siri marked this pull request as ready for review December 19, 2025 18:21
@chandra-siri chandra-siri requested review from a team as code owners December 19, 2025 18:22
@chandra-siri chandra-siri enabled auto-merge (squash) December 19, 2025 18:23
@chandra-siri chandra-siri merged commit bee6089 into main Dec 19, 2025
17 checks passed
@chandra-siri chandra-siri deleted the chore_skip_py_314 branch December 19, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants