Skip to content

Conversation

@b0lle
Copy link
Contributor

@b0lle b0lle commented Mar 27, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes ##2515 🦕

@b0lle b0lle requested review from a team as code owners March 27, 2025 00:28
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 27, 2025
@google-cla
Copy link

google-cla bot commented Mar 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@matthias-busch
Copy link

This is actually a bugfix I need as well!

@KingBain
Copy link

KingBain commented Apr 15, 2025

@chingor13 would like to see this get merged.

@b0lle
Copy link
Contributor Author

b0lle commented Sep 30, 2025

@chingor13 would like to see this get merged.

@b0lle
Copy link
Contributor Author

b0lle commented Jan 6, 2026

@ferrarimarco do you think you could review this?

@ferrarimarco ferrarimarco self-requested a review January 7, 2026 08:10
Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

A few small things to check.

@ferrarimarco
Copy link
Collaborator

@b0lle Thanks for addressing comments. Can you please have a look at linting errors, so we can go ahead with this PR? thanks!

@b0lle
Copy link
Contributor Author

b0lle commented Jan 21, 2026

@ferrarimarco I solved the linting issue, can you trigger the gh-checks please?

@ferrarimarco ferrarimarco merged commit 95a6568 into googleapis:main Jan 21, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants