fix: a bug where a reference to an missing variable in PowerShell would cause an exception#2619
Merged
ferrarimarco merged 2 commits intogoogleapis:mainfrom Feb 13, 2026
Merged
Conversation
…ld cause an exception Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
(just signed the CLA) |
Contributor
Author
|
ping @ferrarimarco and @chingor13 |
Contributor
Author
|
gentle ping @ferrarimarco and @chingor13 |
Added comments to clarify the purpose of type checking for the option parameter.
ferrarimarco
approved these changes
Feb 13, 2026
Collaborator
ferrarimarco
left a comment
There was a problem hiding this comment.
Thanks for this PR!
Contributor
Author
|
Thanks @ferrarimarco ! would you mind pinging others on the team who might be able to approve please? |
Collaborator
|
Done already 🙂 |
chingor13
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2618