Skip to content

Conversation

@wikando-ck
Copy link

@wikando-ck wikando-ck commented Dec 16, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes:

To try this, check out the branch and run

npm run compile && node build/src/bin/release-please.js release-pr \
--token=$GITHUB_TOKEN \
--repo-url=org/repo \
--release-type=node \
--versioning-strategy=calendar \
--calver-scheme=YYY.0M.0D-MICRO \
--dry-run

@google-cla
Copy link

google-cla bot commented Dec 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: calendar Issues related to the Calendar API API. labels Dec 16, 2025
@wikando-ck wikando-ck force-pushed the feat/calendar-versioning-strategy branch from 691ef16 to a43cab4 Compare December 16, 2025 15:27
@wikando-ck wikando-ck force-pushed the feat/calendar-versioning-strategy branch from a43cab4 to e432123 Compare December 16, 2025 16:54
They added too much complexity and would hardly be used in CalVer.
@wikando-ck wikando-ck force-pushed the feat/calendar-versioning-strategy branch from 824d778 to d62481e Compare December 16, 2025 21:52
@wikando-ck wikando-ck force-pushed the feat/calendar-versioning-strategy branch from d62481e to 916156d Compare December 16, 2025 22:01
@wikando-ck wikando-ck marked this pull request as ready for review December 17, 2025 07:49
@wikando-ck wikando-ck requested review from a team as code owners December 17, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: calendar Issues related to the Calendar API API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants