Skip to content

fix(toys-gapic): Workaround for misbehaving cloud console urls #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aandreassa merged 2 commits into from
Jun 13, 2025
Merged

fix(toys-gapic): Workaround for misbehaving cloud console urls #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2da66e9
fix(toys-gapic): Workaround for misbehaving cloud console urls
aandreassa Jun 5, 2025
2126022
Fix rubocop issues
aandreassa Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion toys/gapic/linkinator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def determine_skips gem_name
"^https://rubygems\\.org/gems/#{wrapper_gem_name}",
"^https://cloud\\.google\\.com/ruby/docs/reference/#{gem_name}/latest$",
"^https://rubydoc\\.info/gems/#{gem_name}",
"^https?://stackoverflow\\.com/questions/tagged/google-cloud-platform\\+ruby$"
"^https?://stackoverflow\\.com/questions/tagged/google-cloud-platform\\+ruby$",
"^https://console\\.cloud\\.google\\.com/apis/library/\\\w+\\.googleapis\\.com$"
]
if gem_name == wrapper_gem_name
skip_regexes << "^https://cloud\\.google\\.com/ruby/docs/reference/#{gem_name}-v\\d\\w*/latest$"
Expand Down
3 changes: 2 additions & 1 deletion toys/release/manifest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,6 @@ def default_github_token
return value unless value.empty?
result = exec ["gh", "auth", "status", "-t"], out: :capture, err: :capture
match = /Token: (\w+)/.match(result.captured_out + result.captured_err)
match ? match[1] : nil
return nil unless match
match[1]
end
3 changes: 2 additions & 1 deletion toys/release/please.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ def default_github_token
return value unless value.empty?
result = exec ["gh", "auth", "status", "-t"], out: :capture, err: :capture
match = /Token: (\w+)/.match(result.captured_out + result.captured_err)
match ? match[1] : nil
return nil unless match
match[1]
end

def default_version_path dir, package_name
Expand Down