Skip to content

Commit 0146545

Browse files
authored
chore: remove generator in PR description (#2556)
In this PR: - Remove generator version in PR description We plan to include generator update only when the version is updated, rather than including it in every PR.
1 parent 60cb67f commit 0146545

File tree

3 files changed

+0
-18
lines changed

3 files changed

+0
-18
lines changed

library_generation/generate_pr_description.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ def generate_pr_descriptions(
9292
latest_commit=config.googleapis_commitish,
9393
baseline_commit=baseline_commit,
9494
paths=paths,
95-
generator_version=config.gapic_generator_version,
9695
is_monorepo=config.is_monorepo,
9796
)
9897

@@ -102,7 +101,6 @@ def __get_commit_messages(
102101
latest_commit: str,
103102
baseline_commit: str,
104103
paths: Dict[str, str],
105-
generator_version: str,
106104
is_monorepo: bool,
107105
) -> str:
108106
"""
@@ -117,7 +115,6 @@ def __get_commit_messages(
117115
:param baseline_commit: the oldest commit to be considered in
118116
selecting commit message. This commit should be an ancestor of
119117
:param paths: a mapping from file paths to library_name.
120-
:param generator_version: the version of the generator.
121118
:param is_monorepo: whether to generate commit messages in a monorepo.
122119
:return: commit messages.
123120
"""
@@ -140,7 +137,6 @@ def __get_commit_messages(
140137
latest_commit=latest_commit,
141138
baseline_commit=baseline_commit,
142139
commits=qualified_commits,
143-
generator_version=generator_version,
144140
is_monorepo=is_monorepo,
145141
)
146142

@@ -167,7 +163,6 @@ def __combine_commit_messages(
167163
latest_commit: str,
168164
baseline_commit: str,
169165
commits: Dict[Commit, str],
170-
generator_version: str,
171166
is_monorepo: bool,
172167
) -> str:
173168
messages = [
@@ -181,13 +176,6 @@ def __combine_commit_messages(
181176
)
182177

183178
messages.extend(format_commit_message(commits=commits, is_monorepo=is_monorepo))
184-
messages.extend(
185-
wrap_nested_commit(
186-
[
187-
f"feat: Regenerate with the Java code generator (gapic-generator-java) v{generator_version}"
188-
]
189-
)
190-
)
191179

192180
return "\n".join(messages)
193181

library_generation/test/resources/integration/google-cloud-java/pr-description-golden.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,4 @@ feat: [cloudcontrolspartner] added CloudControlsPartner API
4949

5050
PiperOrigin-RevId: 606720708
5151

52-
END_NESTED_COMMIT
53-
BEGIN_NESTED_COMMIT
54-
feat: Regenerate with the Java code generator (gapic-generator-java) v2.37.0
5552
END_NESTED_COMMIT

library_generation/test/resources/integration/java-bigtable/pr-description-golden.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,4 @@ chore: update retry settings for backup rpcs
1313

1414
PiperOrigin-RevId: 605367937
1515

16-
END_NESTED_COMMIT
17-
BEGIN_NESTED_COMMIT
18-
feat: Regenerate with the Java code generator (gapic-generator-java) v2.35.0
1916
END_NESTED_COMMIT

0 commit comments

Comments
 (0)