address gemini feedback

Author: meltsufin

internal/librariangen/generate/generator_test.go

@@ -418,12 +418,14 @@ func TestUnzip(t *testing.T) {
 		if err != nil {
 			t.Fatalf("failed to open zip file: %v", err)
 		}
+		defer f.Close() // Ensure file is closed
 		zipWriter := zip.NewWriter(f)
 		if _, err := zipWriter.Create("file.txt"); err != nil {
 			t.Fatalf("failed to create file in zip: %v", err)
 		}
-		zipWriter.Close()
-		f.Close()
+		if err := zipWriter.Close(); err != nil { // Check for errors on close
+			t.Fatalf("failed to close zip writer: %v", err)
+		}
 
 		// Make the output directory read-only.
 		readOnlyDir := filepath.Join(e.tmpDir, "readonly")

internal/librariangen/run-generate-library.sh

@@ -83,7 +83,7 @@ if [ ! -d "$LIBRARIANGEN_GOOGLEAPIS_DIR" ]; then
   exit 1
 fi
 echo "Using googleapis source from $LIBRARIANGEN_GOOGLEAPIS_DIR"
-SOURCE_DIR=$(readlink -f "$LIBRARIANGEN_GOOGLEAPIS_DIR")
+SOURCE_DIR=$(cd "$LIBRARIANGEN_GOOGLEAPIS_DIR" && pwd)
 
 # Copy the generate-request.json into the librarian directory.
 cp "testdata/generate/librarian/generate-request.json" "$LIBRARIAN_DIR/"