Skip to content

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Mar 11, 2025

Adding alias to repository-path and api-definitions-path to be compatible with Librarian options

click options allows alias directly, so this change is trivial and does not affect any existing usage cases.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 11, 2025
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhumin8 zhumin8 merged commit 542d98d into main Mar 11, 2025
52 of 53 checks passed
@zhumin8 zhumin8 deleted the add-alias branch March 11, 2025 19:10
)
@click.option(
"--api-definitions-path",
"--api-root",
Copy link
Contributor

@blakeli0 blakeli0 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since api-root is the same as api-definitions-path, can they call our scripts with api-definitions-path directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants