Skip to content

chore: restore showcase #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 14, 2025
Merged

chore: restore showcase #3698

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
135d1dd
chore: restore logging tests in showcase
JoeWang1127 Mar 13, 2025
18b0114
remove redundant showcase samples
JoeWang1127 Mar 13, 2025
acce588
chore: generate libraries at Thu Mar 13 20:39:04 UTC 2025
cloud-java-bot Mar 13, 2025
2f4e4d4
restore deps
JoeWang1127 Mar 13, 2025
652453d
Merge branch 'main' into chore/restore-showcase
JoeWang1127 Mar 14, 2025
fe7e070
make logback version consistent
JoeWang1127 Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java-showcase/gapic-showcase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.3.15</version>
<version>1.2.13</version>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore the version to fix compilation error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what was the compilation error? I did not came across when changing to 1.3.x here.
Also, can you keep logback-classic and logback-core versions consistent. Perhaps add a property for them

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compilation error is #3698 (comment).

I did not came across when changing to 1.3.x here.

I think the showcase test got removed before merging #3686.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. interesting, I might look into this error later.
For now, I agree lets use 1.2.x versions for both

<scope>test</scope>
</dependency>
<dependency>
Expand Down
44 changes: 0 additions & 44 deletions .../java/com/google/showcase/v1beta1/compliance/create/SyncCreateSetCredentialsProvider.java
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions ...java/com/google/showcase/v1beta1/compliance/create/SyncCreateSetCredentialsProvider1.java
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions ...ed/src/main/java/com/google/showcase/v1beta1/compliance/create/SyncCreateSetEndpoint.java
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions .../generated/src/main/java/com/google/showcase/v1beta1/compliance/getenum/AsyncGetEnum.java
View file
Open in desktop

This file was deleted.

42 changes: 0 additions & 42 deletions ...s/generated/src/main/java/com/google/showcase/v1beta1/compliance/getenum/SyncGetEnum.java
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions .../src/main/java/com/google/showcase/v1beta1/compliance/getiampolicy/AsyncGetIamPolicy.java
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions ...d/src/main/java/com/google/showcase/v1beta1/compliance/getiampolicy/SyncGetIamPolicy.java
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions ...ed/src/main/java/com/google/showcase/v1beta1/compliance/getlocation/AsyncGetLocation.java
View file
Open in desktop

This file was deleted.

Loading
Loading