-
Notifications
You must be signed in to change notification settings - Fork 68
ci: Test upper bound dependenices file in Github CI #3877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d5b2be5
to
6e96807
Compare
6e96807
to
e1575ba
Compare
@gemini-cli /review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This PR introduces a new GitHub Actions workflow to test for dependency compatibility using an upper-bounds dependency file. This is a great addition to help ensure the stability of the project.
🔍 General Feedback
- The shell script and workflow are well-structured and easy to understand.
- The use of
workflow_dispatch
is a good feature for manual testing. - There are a few minor issues with duplicate keys in the dependencies file and missing newlines at the end of files.
Overall, this is a solid contribution. Once the minor issues are addressed, this will be ready to merge.
|
|
See b/436286826 for more information
Example workflow run: https://github.com/googleapis/sdk-platform-java/actions/runs/16759125283/job/47449497271?pr=3877
Sample run with upper-bounds file
Running locally:
./.github/scripts/test_dependency_compatibility.sh
Expected error when using an incompatible Deps version
Running locally with Protobuf 4.26.0:
./.github/scripts/test_dependency_compatibility.sh -l protobuf=4.26.0
Results: