-
Notifications
You must be signed in to change notification settings - Fork 67
deps: Bump grpc-java to v1.76.0 #3942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 28 commits
51effdd
d8fb3ce
e7a9b3a
d879011
0aead11
d1ead1f
01d3b8b
cb6ffdc
e7a59b3
e80c3aa
8e3d904
9dbadae
cf8d479
e99a52d
7e9a4e1
c069bcd
6f788c0
9954a2f
524f90e
e317c38
2eee060
5ca594e
b76820d
50b1690
e96f5e1
ba207e7
bca799b
8bb82fa
4756e8b
e989297
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,6 +148,21 @@ private static void loadGrpcNettyClasses(BeforeAnalysisAccess access) { | |
| access, | ||
| NETTY_SHADED_PACKAGE + "org.jctools.queues.MpscArrayQueueConsumerIndexField", | ||
| "consumerIndex"); | ||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerIndexField", | ||
| "producerIndex"); | ||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerLimitField", | ||
| "producerLimit"); | ||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.MpscUnpaddedArrayQueueConsumerIndexField", | ||
| "consumerIndex"); | ||
|
Comment on lines
+151
to
+165
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are essentially copies of the I have kept both |
||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE + "org.jctools.queues.BaseMpscLinkedArrayQueueProducerFields", | ||
|
|
@@ -160,6 +175,21 @@ private static void loadGrpcNettyClasses(BeforeAnalysisAccess access) { | |
| access, | ||
| NETTY_SHADED_PACKAGE + "org.jctools.queues.BaseMpscLinkedArrayQueueConsumerFields", | ||
| "consumerIndex"); | ||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.BaseMpscLinkedUnpaddedArrayQueueProducerFields", | ||
| "producerIndex"); | ||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.BaseMpscLinkedUnpaddedArrayQueueColdProducerFields", | ||
| "producerLimit"); | ||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.BaseMpscLinkedUnpaddedArrayQueueConsumerFields", | ||
| "consumerIndex"); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,9 +26,6 @@ | |
| * [Location.metadata][google.cloud.location.Location.metadata] field. | ||
| * </pre> | ||
| */ | ||
| @javax.annotation.Generated( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think everything here comes strictly from grpc-gen, right? Otherwise I wonder if some postprocessing step stopped adding this annotation.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is from grpc gen code. grpc/grpc-java@f8700a1 |
||
| value = "by gRPC proto compiler", | ||
| comments = "Source: google/cloud/location/locations.proto") | ||
| @io.grpc.stub.annotations.GrpcGenerated | ||
| public final class LocationsGrpc { | ||
|
|
||
|
|
@@ -315,8 +312,8 @@ protected LocationsBlockingV2Stub build( | |
| * </pre> | ||
| */ | ||
| public com.google.cloud.location.ListLocationsResponse listLocations( | ||
| com.google.cloud.location.ListLocationsRequest request) { | ||
| return io.grpc.stub.ClientCalls.blockingUnaryCall( | ||
| com.google.cloud.location.ListLocationsRequest request) throws io.grpc.StatusException { | ||
| return io.grpc.stub.ClientCalls.blockingV2UnaryCall( | ||
| getChannel(), getListLocationsMethod(), getCallOptions(), request); | ||
| } | ||
|
|
||
|
|
@@ -328,8 +325,8 @@ public com.google.cloud.location.ListLocationsResponse listLocations( | |
| * </pre> | ||
| */ | ||
| public com.google.cloud.location.Location getLocation( | ||
| com.google.cloud.location.GetLocationRequest request) { | ||
| return io.grpc.stub.ClientCalls.blockingUnaryCall( | ||
| com.google.cloud.location.GetLocationRequest request) throws io.grpc.StatusException { | ||
| return io.grpc.stub.ClientCalls.blockingV2UnaryCall( | ||
| getChannel(), getGetLocationMethod(), getCallOptions(), request); | ||
| } | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would it make sense to add a quick explainer on how grpc needs this and maybe reference grpc/grpc-java#12243?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments above about the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the WORKSPACE file in googleapis needs this change as well, can we follow up on that once this change is released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! That is the plan!