-
Notifications
You must be signed in to change notification settings - Fork 67
deps: Bump Guava to v33.5.0 #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine dependency update, specifically bumping the Guava library to its latest stable version, 33.5.0-jre. This ensures the project benefits from the most recent bug fixes, performance enhancements, and features provided by the Guava library, maintaining compatibility and stability across the codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Guava dependency from version 33.4.0-jre to 33.5.0-jre. The change is correctly applied in the guava.version property of the parent pom.xml, ensuring that all modules will use the updated version. This is a straightforward and correct dependency update.
|
Enforcer error: |
|
Still errors: |
|
Latest error: |
|
Ah... I think I figured out the issue with this. We have errorprone and j2objc version declared twice... once in pom-parent and once in third-party deps pom.xml. I will remove one of the references |
|
|



BEGIN_COMMIT_OVERRIDE
deps: Bump guava to v33.5.0
deps: Bump errorprone-annotations to v2.42.0
deps: Bump j2objc-annotations to v3.1
END_COMMIT_OVERRIDE