Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Oct 15, 2025

BEGIN_COMMIT_OVERRIDE
deps: Bump guava to v33.5.0
deps: Bump errorprone-annotations to v2.42.0
deps: Bump j2objc-annotations to v3.1
END_COMMIT_OVERRIDE

@lqiu96 lqiu96 requested a review from mpeddada1 October 15, 2025 18:56
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 15, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine dependency update, specifically bumping the Guava library to its latest stable version, 33.5.0-jre. This ensures the project benefits from the most recent bug fixes, performance enhancements, and features provided by the Guava library, maintaining compatibility and stability across the codebase.

Highlights

  • Dependency Update: The Guava library dependency has been updated from version "33.4.0-jre" to "33.5.0-jre".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Guava dependency from version 33.4.0-jre to 33.5.0-jre. The change is correctly applied in the guava.version property of the parent pom.xml, ensuring that all modules will use the updated version. This is a straightforward and correct dependency update.

mpeddada1
mpeddada1 previously approved these changes Oct 15, 2025
@lqiu96
Copy link
Member Author

lqiu96 commented Oct 15, 2025

Enforcer error:

Error:  Require upper bound dependencies error for com.google.errorprone:error_prone_annotations:2.38.0 paths to dependency are:
Error:  +-com.google.api:api-common:2.53.4-SNAPSHOT
Error: [ERROR]   +-com.google.errorprone:error_prone_annotations:2.38.0
Error:  and
Error:  +-com.google.api:api-common:2.53.4-SNAPSHOT
Error:    +-com.google.guava:guava:33.5.0-jre
Error:      +-com.google.errorprone:error_prone_annotations:2.41.0
Error:  , 
Error:  Require upper bound dependencies error for com.google.j2objc:j2objc-annotations:3.0.0 paths to dependency are:
Error:  +-com.google.api:api-common:2.53.4-SNAPSHOT
Error:    +-com.google.j2objc:j2objc-annotations:3.0.0
Error:  and
Error:  +-com.google.api:api-common:2.53.4-SNAPSHOT
Error:    +-com.google.guava:guava:33.5.0-jre
Error:      +-com.google.j2objc:j2objc-annotations:3.1

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 15, 2025
@lqiu96
Copy link
Member Author

lqiu96 commented Oct 15, 2025

Still errors:

Error:  +-com.google.api:gax:2.70.4-SNAPSHOT
Error:    +-com.google.api:api-common:2.53.4-SNAPSHOT
Error:      +-com.google.j2objc:j2objc-annotations:3.0.0
Error:  and
Error:  +-com.google.api:gax:2.70.4-SNAPSHOT
Error:    +-com.google.protobuf:protobuf-java-util:3.25.8
Error:      +-com.google.j2objc:j2objc-annotations:2.8
Error:  and
Error:  +-com.google.api:gax:2.70.4-SNAPSHOT
Error:    +-com.google.guava:guava:33.5.0-jre
Error:      +-com.google.j2objc:j2objc-annotations:3.1
Error:  and
Error:  +-com.google.api:gax:2.70.4-SNAPSHOT
Error:    +-com.google.auth:google-auth-library-oauth2-http:1.39.1
Error:      +-com.google.http-client:google-http-client:1.47.1 (managed) <-- com.google.http-client:google-http-client:1.47.0
Error:        +-com.google.j2objc:j2objc-annotations:3.0.0

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 15, 2025
@lqiu96
Copy link
Member Author

lqiu96 commented Oct 15, 2025

Latest error:

Error:  Require upper bound dependencies error for com.google.errorprone:error_prone_annotations:2.38.0 paths to dependency are:
Error:  +-com.google.api.grpc:grpc-google-iam-v2beta:1.56.4-SNAPSHOT
Error:    +-io.grpc:grpc-api:1.71.0
Error:      +-com.google.errorprone:error_prone_annotations:2.38.0 (managed) <-- com.google.errorprone:error_prone_annotations:2.30.0
Error:  and
Error:  +-com.google.api.grpc:grpc-google-iam-v2beta:1.56.4-SNAPSHOT
Error:    +-io.grpc:grpc-stub:1.71.0
Error:      +-com.google.errorprone:error_prone_annotations:2.38.0 [runtime] (managed) <-- com.google.errorprone:error_prone_annotations:2.30.0 [runtime]
Error:  and
Error:  +-com.google.api.grpc:grpc-google-iam-v2beta:1.56.4-SNAPSHOT
Error:    +-com.google.guava:guava:33.5.0-jre
Error:      +-com.google.errorprone:error_prone_annotations:2.38.0 (managed) <-- com.google.errorprone:error_prone_annotations:2.41.0
Error:  ]

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Oct 15, 2025
@lqiu96
Copy link
Member Author

lqiu96 commented Oct 15, 2025

Ah... I think I figured out the issue with this. We have errorprone and j2objc version declared twice... once in pom-parent and once in third-party deps pom.xml. I will remove one of the references

@sonarqubecloud
Copy link

@lqiu96 lqiu96 requested a review from mpeddada1 October 15, 2025 21:18
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lqiu96 lqiu96 merged commit 8d6c1f9 into main Oct 16, 2025
61 of 62 checks passed
@lqiu96 lqiu96 deleted the upgrade-guava branch October 16, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants