tests: Add java-showcase-3.25.8. #4010
Conversation
Summary of ChangesHello @blakeli0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new version of the Java GAPIC Showcase, specifically Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new test module java-showcase-3.25.8, which appears to be a copy of gapic-showcase generated with protobuf 3.25.8 to test compatibility. The changes consist of adding a large number of generated Java files, a pom.xml, and a README.md.
My review has identified a critical issue in the pom.xml with an invalid dependency version that will likely cause the build to fail. I've also found a minor style issue in the README.md that could be improved for better quality and consistency. Please see my detailed comments.
| <gapic-showcase.version>0.36.2</gapic-showcase.version> | ||
| <!-- This is the last version supporting slf4j 1.x, do not upgrade --> | ||
| <slf4j1-logback.version>1.2.13</slf4j1-logback.version> | ||
| <slf4j2-logback.version>1.5.21</slf4j2-logback.version> |
There was a problem hiding this comment.
The version 1.5.21 for slf4j2-logback.version does not appear to be a valid version for logback-classic or logback-core. This will likely cause a build failure when resolving dependencies. Please verify the correct version. For example, the latest version in the 1.4.x series is 1.4.14, and the latest stable version is 1.5.6.
| @@ -0,0 +1,2 @@ | |||
| This is a copy of [GAPIC Showcase](https://github.com/googleapis/gapic-showcase) with protobuf 3.25.8 gen code. | |||
| This is intended to test the compatibility between protobuf-java runtime v4.33.0 and gen code 3.25.8. No newline at end of file | |||
There was a problem hiding this comment.
There is trailing whitespace at the end of this line. It should be removed to maintain code style consistency.
| This is intended to test the compatibility between protobuf-java runtime v4.33.0 and gen code 3.25.8. | |
| This is intended to test the compatibility between protobuf-java runtime v4.33.0 and gen code 3.25.8. |
|
|
2 participants
Add a new module java-showcase-3.25.8. This is a copy of the java-showcase module with a different version (3.25.8) of protobuf gen code. This is intended to test the compatibility between protobuf runtime v4.33.0 and gen code 3.25.8.
Add a new step in CI to test this module.