Skip to content

chore: Filter out non-semver versions in update_generation_config.sh #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakeli0 merged 1 commit into from
Dec 16, 2025
Merged

chore: Filter out non-semver versions in update_generation_config.sh #4024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...rary_generation/owlbot/templates/java_library/.github/scripts/update_generation_config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,17 @@ function get_latest_released_version() {
group_id_url_path="$(sed 's|\.|/|g' <<< "${group_id}")"
url="https://repo1.maven.org/maven2/${group_id_url_path}/${artifact_id}/maven-metadata.xml"
xml_content=$(curl -s --fail "${url}")
latest=$(xmllint --xpath 'metadata/versioning/latest/text()' - <<< "${xml_content}")

# 1. Extract all version tags
# 2. Strip the XML tags to leave just the version numbers
# 3. Filter for strictly numbers.numbers.numbers (e.g., 2.54.0)
# 4. Sort by version (V) and take the last one (tail -n 1)
latest=$(echo "${xml_content}" \
| grep -oE '<version>[0-9]+\.[0-9]+\.[0-9]+</version>' \
| sed -E 's/<[^>]+>//g' \
| sort -V \
| tail -n 1)
Comment on lines +22 to +30
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This pipeline of grep, sed, sort, and tail to find the latest stable version is complex and potentially brittle. A much simpler and more robust approach is to leverage the <release> tag within the maven-metadata.xml file. According to the Maven metadata specification, the <release> tag contains the latest release version, which excludes pre-release versions like RCs and snapshots. This is exactly what's needed here.

You can replace this entire block with a single xmllint command, which is already a dependency for this script.

Suggested change
# 1. Extract all version tags
# 2. Strip the XML tags to leave just the version numbers
# 3. Filter for strictly numbers.numbers.numbers (e.g., 2.54.0)
# 4. Sort by version (V) and take the last one (tail -n 1)
latest=$(echo "${xml_content}" \
| grep -oE '<version>[0-9]+\.[0-9]+\.[0-9]+</version>' \
| sed -E 's/<[^>]+>//g' \
| sort -V \
| tail -n 1)
latest=$(xmllint --xpath 'string(metadata/versioning/release)' - <<< "${xml_content}")

Copy link
Contributor Author

@blakeli0 blakeli0 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion does not take pre-release versions like -rc into consideration.


if [[ -z "${latest}" ]]; then
echo "The latest version of ${group_id}:${artifact_id} is empty."
echo "The returned json from maven.org is invalid: ${json_content}"
Expand Down
Loading