Skip to content

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jan 24, 2025

This allows the build.sh file to only load the credentials if they are present. With our new instances, we will rely on ADC and environment variables to configure auth for tests rather than exported service account keys.

This allows the presubmit to run on both our old Kokoro infra and new Kokoro infra.

See googleapis/python-bigquery#2120 for example of the tests working on both legacy and new infra in parallel.

@chingor13 chingor13 requested a review from a team as a code owner January 24, 2025 19:16
@chingor13 chingor13 requested a review from parthea January 24, 2025 19:16
@parthea parthea changed the title ci: conditionally load credentials chore(python): conditionally load credentials in .kokoro/build.sh Feb 21, 2025
@parthea parthea enabled auto-merge (squash) February 21, 2025 19:22
@parthea parthea merged commit aa69fb7 into master Feb 21, 2025
10 checks passed
@parthea parthea deleted the chingor13-patch-2 branch February 21, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants