Pass auto_use_my_metrics=False to ufo2ft for variable fonts#1154
Merged
anthrotype merged 3 commits intomainfrom Aug 27, 2025
Merged
Pass auto_use_my_metrics=False to ufo2ft for variable fonts#1154anthrotype merged 3 commits intomainfrom
anthrotype merged 3 commits intomainfrom
Conversation
This is fix/prevent the issue described in fonttools/fonttools#3912 Also see the discussion in googlefonts/fontc#1614 The PR is intended to match fontc's default behavior whereby the USE_MY_METRICS glyf component flag is only automatically set for static font builds, and no longer also for variable font builds, where this can be problematic when composite/component glyph metrics are inconsistent across masters and the HVAR table (normally preferred over glyf+gvar phantom points) gets dropped.
Member
Author
|
fontmake already had a By default, fontmake will continue to pass |
anthrotype
added a commit
to googlefonts/ufo2ft
that referenced
this pull request
Aug 27, 2025
same as googlefonts/fontmake#1154, for when ufo2ft is called programmatically as opposed to through fontmake CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fix/prevent the issue described in fonttools/fonttools#3912
Also see the discussion in googlefonts/fontc#1614
The PR is intended to match fontc's default behavior whereby the USE_MY_METRICS glyf component flag is only automatically set for static font builds, and no longer also for variable font builds, where this can be problematic when composite/component glyph metrics are inconsistent across masters and the HVAR table (normally preferred over glyf+gvar phantom points) gets dropped.