Fix test failures after skia-pathops m113 to m143 update#331
Merged
anthrotype merged 1 commit intomainfrom Nov 11, 2025
Merged
Conversation
After updating skia-pathops from m113 to m143 in fonttools/skia-pathops#81, 5 tests were failing on macOS due to floating-point precision differences in stroke expansion. These differences arise from cross-platform floating-point variations (macOS ARM vs Linux x86_64) and minor algorithmic improvements in skia-pathops m143. Rather than regenerating all expected files, we round both actual and expected output to the minimum precision needed for each test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating skia-pathops from m113 to m143 in fonttools/skia-pathops#81, 5 tests were failing on macOS due to floating-point precision differences in stroke expansion. These differences arise from cross-platform floating-point variations (macOS ARM vs Linux x86_64) and minor algorithmic improvements in skia-pathops m143. Rather than regenerating all expected files, we round both actual and expected output to the minimum precision needed for each test.