Added 3d samples #305
Merged
Added 3d samples #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willum070
reviewed
Apr 11, 2025
willum070
reviewed
Apr 11, 2025
willum070
reviewed
Apr 11, 2025
Comment on lines
1
to
13
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
Collaborator
There was a problem hiding this comment.
Please use the short SPDX license header for all HTML, TS, CSS files.
/*
- @license
- Copyright 2025 Google LLC. All Rights Reserved.
- SPDX-License-Identifier: Apache-2.0
*/
willum070
reviewed
Apr 11, 2025
Collaborator
There was a problem hiding this comment.
This file should not be in the commit.
willum070
approved these changes
Apr 11, 2025
willum070
reviewed
Apr 11, 2025
.DS_Store
Outdated
Collaborator
There was a problem hiding this comment.
GLOBAL: Remove all instances of .DS_Store file.
willum070
requested changes
Apr 11, 2025
Collaborator
willum070
left a comment
willum070
left a comment
There was a problem hiding this comment.
Just a few issues:
- You should be using short SPDX license headers: https://docs.google.com/document/d/1SvHsgsF_2beKPjlWnlSmccl7Qs-nWxIF5cTIAfgmQkA/edit?usp=sharing Sorry I spaced on that earlier.
- The commit contains multiple instances of .DS_Store, which must be removed.
- A comment has a mis-spelled word.
Other than that it looks great! So many 3D samples!!
…remove said files from PR
willum070
approved these changes
Apr 14, 2025
willum070
requested changes
Apr 14, 2025
Collaborator
willum070
left a comment
willum070
left a comment
There was a problem hiding this comment.
Please remove package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.