Skip to content

Update Place UI Kit Text and Nearby Search demos#663

Closed
ejhaselden wants to merge 4 commits intomainfrom
update-search-demos
Closed

Update Place UI Kit Text and Nearby Search demos#663
ejhaselden wants to merge 4 commits intomainfrom
update-search-demos

Conversation

@ejhaselden
Copy link
Contributor

No description provided.

@ejhaselden ejhaselden requested a review from willum070 July 17, 2025 06:37
@snippet-bot
Copy link

snippet-bot bot commented Jul 17, 2025

Here is the summary of changes.

You are about to add 5 region tags.
You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Collaborator

@willum070 willum070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample doesn't load. I get "places.js:1034 : Ignoring with no location restriction."

When I make a selection I get this: "main.js:301 POST https://places.googleapis.com/$rpc/google.maps.places.v1.Places/SearchNearby 400 (Bad Request)
_.B.send @ main.js:301
fba @ main.js:141
(anonymous) @ main.js:310
(anonymous) @ main.js:310
intercept @ main.js:503
await in intercept
(anonymous) @ main.js:139
Fg @ main.js:311
Dg @ main.js:311
X9.searchNearby @ places_impl.js:55
Wqb @ places_impl.js:35
zoa @ places.js:137
await in zoa
(anonymous) @ places.js:1057
await in (anonymous)
EF @ main.js:263
await in EF
ns @ main.js:262
await in ns
_.ps @ main.js:263
nF @ places.js:1057
Oj @ places.js:1057
hm @ main.js:404
Bba @ main.js:195
Tm @ main.js:404
await in Tm
_.np @ main.js:194
set @ main.js:193
py @ places.js:739
Oj @ places.js:739
hm @ main.js:404
Bba @ main.js:195
Tm @ main.js:404
await in Tm
_.np @ main.js:194
set @ main.js:193
searchPlaces @ index.js:78
(anonymous) @ index.js:51Understand this error
main.js:196 : Encountered a network request error: PLACES_NEARBY_SEARCH: INVALID_ARGUMENT: Error in searchNearby: Longitude must be in the range [-180.0, +180.0]."

Added location-restriction
@ejhaselden ejhaselden requested a review from willum070 July 18, 2025 06:21
Copy link
Collaborator

@willum070 willum070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nearby search demo is not functioning as expected.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get an error when I run this sample locally. Upon selection of a type, the console shows this:
main.js:301 POST https://places.googleapis.com/$rpc/google.maps.places.v1.Places/SearchNearby 400 (Bad Request)
(anonymous) @ main.js:301
...snip...
(anonymous) @ index.js:51Understand this error
main.js:196 : Encountered a network request error: PLACES_NEARBY_SEARCH: INVALID_ARGUMENT: Error in searchNearby: Longitude must be in the range [-180.0, +180.0].

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following error upon loading: places.js:1034 : Ignoring with no text query.

Otherwise this demo seems to be working as expected.

Added text query to <gmp-place-text-search-request>
Copy link
Collaborator

@willum070 willum070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further investigation reveals that there's a fundamental problem with how the map object has been declared. This is subtle and hard to solve!

@ejhaselden
Copy link
Contributor Author

Demo guidance has changed; closing PR to start fresh with new demos

@ejhaselden ejhaselden closed this Jul 28, 2025
@ejhaselden ejhaselden deleted the update-search-demos branch July 28, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments