Skip to content

Conversation

@willum070
Copy link
Collaborator

@willum070 willum070 commented Sep 17, 2025

Gives Place Autocomplete session token sample a much-needed overhaul!

  • Added a map! Now results are indicated by a marker.
  • Upgraded to use gmp-map element and dynamic library import.
  • Added a text indication for the session token count.
  • Made UI a11y-friendlier.
  • Improved the visual appearance of the UI.

Change-Id: Ica31d9553f244961a67360655e5ca1e40510d324

Change-Id: Ica31d9553f244961a67360655e5ca1e40510d324
@willum070 willum070 changed the title fix: Quality and standards improvements. fix: Quality and standards improvements for Place AC session. Sep 17, 2025
Copy link

@chrisjshull chrisjshull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also

titleElement.innerText = `Query predictions for "${request.input}"`;

should be

titleElement.innerText = `Place predictions for "${request.input}"`;

@noelle-jung
Copy link
Contributor

noelle-jung commented Sep 18, 2025

Btw the first jsfiddle you linked to in your first comment is not Places AC related!

Removed unused listener for map loading event.
@snippet-bot
Copy link

snippet-bot bot commented Sep 24, 2025

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Removed language and region properties from the configuration.
Removed unnecessary refreshToken call before adding event listener. Previously the token count had been incremented by 1 before the user took an action; the count should reflect the number of selections the user made.
@noelle-jung
Copy link
Contributor

#766 (comment)

Copy link
Contributor

@noelle-jung noelle-jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some styling suggestions

Refactor styles for place-button and results list.
@willum070 willum070 merged commit 97702cf into main Oct 3, 2025
8 checks passed
@willum070 willum070 deleted the fix-place-ac-session branch October 3, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants