-
Notifications
You must be signed in to change notification settings - Fork 7
fix: Quality and standards improvements for Place AC session. #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: Ica31d9553f244961a67360655e5ca1e40510d324
chrisjshull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also
titleElement.innerText = `Query predictions for "${request.input}"`;
should be
titleElement.innerText = `Place predictions for "${request.input}"`;
|
Btw the first jsfiddle you linked to in your first comment is not Places AC related! |
Removed unused listener for map loading event.
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Removed language and region properties from the configuration.
Removed unnecessary refreshToken call before adding event listener. Previously the token count had been incremented by 1 before the user took an action; the count should reflect the number of selections the user made.
noelle-jung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some styling suggestions
Refactor styles for place-button and results list.
Gives Place Autocomplete session token sample a much-needed overhaul!
Change-Id: Ica31d9553f244961a67360655e5ca1e40510d324