Skip to content

fix: Updates firebase.json public path; deletes log lines from app.sh #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willum070 merged 1 commit into from
Feb 8, 2025
Merged

fix: Updates firebase.json public path; deletes log lines from app.sh #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions firebase.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
{
"hosting": {
"public": "dist",
"public": ".",
"ignore": [
"firebase.json",
"**/.*",
"**/node_modules/**"
]
},
"rewrites": [
{
"source": "/samples/**/index.js",
"destination": "/samples/**/app/dist/index-*.js"
}
]
],
"nodeVersion": "22"
}
}
11 changes: 3 additions & 8 deletions samples/app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

# Copy/generate files for:
# - Cloud Shell
# Copy/generate:
# - Files for Cloud Shell
# - Vite build output for hosting

# Generate JSFiddle output as part of the build process.
Expand All @@ -25,10 +25,8 @@ cp "${OUTPUT_DIR}/${NAME}/style.css" "${APP_DIR}/style.css"
cp "${OUTPUT_DIR}/${NAME}/package.json" "${APP_DIR}/package.json"
cp "${OUTPUT_DIR}/${NAME}/tsconfig.json" "${APP_DIR}/tsconfig.json"
cp "${OUTPUT_DIR}/${NAME}/README.md" "${APP_DIR}/README.md"
cp "${OUTPUT_DIR}/.env" "${APP_DIR}/.env" # TODO: Update the .env with the new API key.
cp "${OUTPUT_DIR}/.env" "${APP_DIR}/.env"
cp -r "${OUTPUT_DIR}/${NAME}/dist" "${MAIN_DIR}"
echo "OUTPUT_DIR ${OUTPUT_DIR}"
echo "MAIN_DIR ${MAIN_DIR}"

# Generate .eslintsrc.json
touch "${APP_DIR}/.eslintsrc.json"
Expand All @@ -47,6 +45,3 @@ cat > "${APP_DIR}/.eslintsrc.json" << EOF
}
}
EOF


## TODO: Update this to copy