Skip to content

chore: refactor StreetViewCameraPositionState setPosition #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkhawk merged 3 commits into from
Jan 23, 2025
Merged

chore: refactor StreetViewCameraPositionState setPosition #647

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d1e5c8
Update StreetViewCameraPositionState.kt
GeorgCantor Nov 10, 2024
59f2482
Merge branch 'main' into patch-1
dkhawk Dec 13, 2024
4256f6a
Merge branch 'main' into patch-1
dkhawk Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ...src/main/java/com/google/maps/android/compose/streetview/StreetViewCameraPositionState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,10 @@ public class StreetViewCameraPositionState private constructor() {
* @param source the source of the panoramas
*/
public fun setPosition(position: LatLng, radius: Int? = null, source: StreetViewSource? = null) {
if (radius == null && source == null) {
panorama?.setPosition(position)
} else if (radius != null && source == null) {
panorama?.setPosition(position, radius)
} else if (radius != null) {
panorama?.setPosition(position, radius, source)
when {
radius != null && source != null -> panorama?.setPosition(position, radius, source)
radius != null -> panorama?.setPosition(position, radius)
else -> panorama?.setPosition(position)
}
}

Expand All @@ -96,4 +94,4 @@ public class StreetViewCameraPositionState private constructor() {
public operator fun invoke(): StreetViewCameraPositionState =
StreetViewCameraPositionState()
}
}
}
Loading