Skip to content

refactor: Convert addAttributionId to a suspend function #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkhawk merged 3 commits into from
Aug 28, 2025
Merged

refactor: Convert addAttributionId to a suspend function #742

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bebba20
refactor: Convert addAttributionId to a suspend function
dkhawk Aug 26, 2025
d487260
Merge branch 'main' into refactor-add-attribution-id
dkhawk Aug 27, 2025
d1fee03
Merge branch 'main' into refactor-add-attribution-id
dkhawk Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions maps-compose/src/main/java/com/google/maps/android/compose/internal/MapsApiAttribution.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ import androidx.compose.runtime.State
import androidx.compose.runtime.mutableStateOf
import com.google.android.gms.maps.MapsApiSettings
import com.google.maps.android.compose.meta.AttributionId
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import java.util.concurrent.atomic.AtomicBoolean

/**
Expand All @@ -27,9 +26,9 @@ internal object MapsApiAttribution {
*
* @param context The context to use to add the attribution ID.
*/
fun addAttributionId(context: Context) {
suspend fun addAttributionId(context: Context) {
if (hasBeenCalled.compareAndSet(false, true)) {
CoroutineScope(Dispatchers.IO).launch {
withContext(Dispatchers.IO) {
MapsApiSettings.addInternalUsageAttributionId(context, AttributionId.VALUE)
_isInitialized.value = true
}
Expand Down
Loading