Skip to content

feat!: Add support for setOnInfoWindowCloseListener() for Markers #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bshi
Copy link

@bshi bshi commented Jul 11, 2025

BREAKING CHANGE: ClusterRenderer adds two InfoWindowClose listeners. Applications that used ClusterRenderer or MarkerManager with GoogleMap.setOnInfoWindowCloseListener must now register their listener(s) with relevant collection/clustering management class.

Circa 2020, we added some more InfoWindow-related events to Marker/ClusterManager but InfoWindowClose was not included. This change addresses a discrepancy in the class documentation for MarkerManager which claims to "[d]elegates all Marker-related events to each ...". The close handler has been missing.

[1] 8a3fc01

Addresses #1540


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Edit the title of this pull request with a semantic commit prefix (e.g. "fix: "), which is necessary for automated release workflows to decide whether to generate a new release and what type it should be.
  • Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

BREAKING CHANGE: ClusterRenderer adds two InfoWindowClose listeners.
Applications that used ClusterRenderer or MarkerManager with
GoogleMap.setOnInfoWindowCloseListener must now register their
listener(s) with relevant collection/clustering management class.

Circa 2020, we added some more InfoWindow-related events to
Marker/ClusterManager but InfoWindowClose was not included. This
change addresses a discrepancy in the class documentation for
MarkerManager which claims to "[d]elegates all Marker-related events
to each ...".  The close handler has been missing.

[1] googlemaps@8a3fc01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants