fix: Correct continuous zoom clustering implementation #1587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clustering logic for the ContinuousZoomEuclideanCentroidAlgorithm was previously misplaced in the
getClusteringItemsmethod. This resulted in the base class's clustering algorithm being used, which does not correctly apply the intended Euclidean distance check.This change refactors the implementation by moving the continuous zoom scaling and Euclidean distance logic into an
overridden
getClustersmethod, ensuring the correct clustering algorithm is executed. ThegetClusteringItemsmethod now reverts to its default behavior of returning all items to be considered for clustering.