Conversation
yuethomas
approved these changes
Jul 19, 2023
wangela
requested changes
Jul 31, 2023
Member
There was a problem hiding this comment.
I recommend you migrate to release-please for this repo, but if you're not ready to do that yet you can adjust these dependencies to work for a while longer (until support for Node 14 ends in GitHub Actions).
Option "Migrate to Release Please"
- Follow the install instructions at https://github.com/google-github-actions/release-please-action to set up the action and configure it for
nodetype releases. - An example of another repo using this in the googlemaps organization is Extended Component Library. Their workflow is more complicated because it involves publishing to npm.
- Delete this release.yml and the .releaserc file to stop using this release workflow
Option "Stay on Semantic Release"
- Copy the versions specified in L49-62 of https://github.com/googlemaps/android-maps-compose/blob/main/.github/workflows/release.yml#L49-L62 to pin everything to the Node 14-compatible versions which will work with semantic-release-action since it doesn't support Node 18 yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕